Skip to content

Conversation

@steffenlarsen
Copy link
Contributor

This commit adds variants to the executable target SYCLBIN tests that only creates SYCLBINs with AOT binary images for BMG G21. This is to help test that AOT works for SYCLBIN, avoiding tests always falling back to SPIR-V and giving the false impression that AOT works as intended.

This commit adds variants to the executable target SYCLBIN tests that
only creates SYCLBINs with AOT binary images for BMG G21. This is to
help test that AOT works for SYCLBIN, avoiding tests always falling back
to SPIR-V and giving the false impression that AOT works as intended.

Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can have a local format.py in SYCLBIN such that

// REQUIRES-EXEC: ...
// REQUIRES-OBJ: ...
// REQUIRES-INPUT: ...
// RUN-EXEC: <exec-specific>
// RUN-OBJ: <object-specific>
// RUN-INPUT: <input-specific>
// RUN: %{build} ...
// RUN: %{run} ...

would generate three tests "on-the-fly". That can be investigated later though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants